Skip to content

Conversation

CharlyPoppins
Copy link
Contributor

@CharlyPoppins CharlyPoppins commented Mar 13, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43345

@Assert\DivisibleBy was not working with 0.01 and smaller divider.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title fix #43345 @Assert\DivisibleBy [Validator] fix #43345 @Assert\DivisibleBy Mar 13, 2022
@derrabus
Copy link
Member

Thank you for your PR. Plase apply the fix suggested by fabbot.

@CharlyPoppins
Copy link
Contributor Author

Tests failed in AppVeyor seems unrelated.

@fabpot
Copy link
Member

fabpot commented Mar 26, 2022

Thank you @CharlyPoppins.

@fabpot fabpot merged commit 1d1dcf8 into symfony:5.4 Mar 26, 2022
@CharlyPoppins CharlyPoppins deleted the ticket_43345 branch March 28, 2022 17:56
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants