Skip to content

Conversation

sveneld
Copy link
Contributor

@sveneld sveneld commented Feb 15, 2022

Q A
Branch? 4.4
Bug fix? yes
License MIT

If $type is a scalar compiler pass should not check it in function is_subclass_of($type, \UnitEnum::class), because is_subclass_of trying to autoload class with name array, string, etc.

Related to #44979

@carsonbot carsonbot added this to the 6.1 milestone Feb 15, 2022
@sveneld sveneld changed the base branch from 6.1 to 5.4 February 15, 2022 14:00
@sveneld
Copy link
Contributor Author

sveneld commented Feb 16, 2022

@nicolas-grekas take a look, please

@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 4.4 Feb 16, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 4.4 February 16, 2022 14:23
@nicolas-grekas
Copy link
Member

Thank you @sveneld.

@nicolas-grekas nicolas-grekas merged commit 8056126 into symfony:4.4 Feb 16, 2022
@sveneld sveneld deleted the fix_type_bindings branch February 16, 2022 14:31
This was referenced Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants