Skip to content

[ErrorHandler] Report overridden @final constants #45303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2022
Merged

[ErrorHandler] Report overridden @final constants #45303

merged 1 commit into from
Feb 5, 2022

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Feb 3, 2022

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? -
Tickets #44268
License MIT
Doc PR -

See #44268 and https://wiki.php.net/rfc/final_class_const.

@fancyweb fancyweb requested a review from yceruto as a code owner February 3, 2022 17:18
@carsonbot carsonbot added this to the 6.1 milestone Feb 3, 2022
@fancyweb fancyweb force-pushed the error-handler/final-const branch from 7d25804 to 22ed0ea Compare February 3, 2022 17:22
yceruto
yceruto approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolas-grekas
nicolas-grekas approved these changes Feb 4, 2022
View reviewed changes
@fancyweb fancyweb force-pushed the error-handler/final-const branch from 22ed0ea to 16e28c0 Compare February 4, 2022 17:17
@fancyweb fancyweb force-pushed the error-handler/final-const branch from 16e28c0 to 0b82bda Compare February 4, 2022 17:22
@fabpot
Copy link
Member

fabpot commented Feb 5, 2022

Thank you @fancyweb.

@fabpot fabpot merged commit 0758e59 into symfony:6.1 Feb 5, 2022
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
ErrorHandler Feature Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@fancyweb @fabpot @nicolas-grekas @derrabus @yceruto @carsonbot