[Console] use STDOUT/ERR in ConsoleOutput to save opening too many file descriptors #45053
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jan 18, 2022
chalasr
reviewed
Jan 18, 2022
fd7b1b0 to
6eaf9e6
Compare
fabpot
approved these changes
Jan 19, 2022
|
Thank you @nicolas-grekas. |
|
Can confirm this fixes the issue for me. Thanks. |
|
Thank you 👍 it fixed one issue we have with Rector tests |
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jtojnar can you please give this patch a try and report back?