Skip to content

[HttpClient] fix resetting DNS/etc when calling CurlHttpClient::reset() #45015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

[HttpClient] fix resetting DNS/etc when calling CurlHttpClient::reset() #45015

merged 1 commit into from
Jan 14, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44900
License MIT
Doc PR -

This PR reverts #44625 and uses a new curl-share handle instead to reset any state.

@carsonbot carsonbot added this to the 4.4 milestone Jan 13, 2022
@nicolas-grekas nicolas-grekas force-pushed the hc-fix-curl branch 5 times, most recently from d956af9 to dfcda2a Compare January 13, 2022 18:34
@nicolas-grekas nicolas-grekas merged commit 5f6d897 into symfony:4.4 Jan 14, 2022
@nicolas-grekas nicolas-grekas deleted the hc-fix-curl branch January 18, 2022 09:03
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot