Skip to content

[String] Fix requiring wcswitch table several times #44469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2021
Merged

[String] Fix requiring wcswitch table several times #44469

merged 1 commit into from
Dec 11, 2021

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Dec 6, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Ref https://wiki.php.net/rfc/static_variable_inheritance

Since AbstractUnicodeString is an abstract class, the tables are required for every child.

@carsonbot carsonbot added this to the 5.3 milestone Dec 6, 2021
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit a18bd1d into symfony:5.3 Dec 11, 2021
@fancyweb fancyweb deleted the string/req-static branch December 11, 2021 10:35
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review String
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot