Skip to content

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 15, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

I was wrong :(, there is more to deprecate in security: the old remember me implementation.

@wouterj
Copy link
Member Author

wouterj commented Aug 15, 2021

Fabbot error is a false positive

@carsonbot
Copy link

Hey!

I think @dmaicher has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@@ -1,9 +1,12 @@
CHANGELOG
=========


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra white line

@fabpot fabpot force-pushed the pull-41613/rememberme branch from a31a2ee to 03e5da1 Compare August 16, 2021 08:26
@fabpot
Copy link
Member

fabpot commented Aug 16, 2021

Thank you @wouterj.

@fabpot fabpot merged commit d1a2d21 into symfony:5.4 Aug 16, 2021
@wouterj wouterj deleted the pull-41613/rememberme branch August 16, 2021 08:35
This was referenced Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants