[TwigBridge] do not merge label classes into expanded choice labels #42323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 30, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #40005 |
| License | MIT |
| Doc PR |
|
CI failure looks related Status: Needs work |
a0c4375 to
4ec3be7
Compare
|
After having another look I fail to see how the failure is related. Status: Needs Review |
|
Hey! I think @ker0x has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
ping @symfony/mergers |
ogizanagi
reviewed
Nov 13, 2021
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig
Show resolved
Hide resolved
chalasr
approved these changes
Nov 18, 2021
yceruto
approved these changes
Nov 18, 2021
ogizanagi
approved these changes
Nov 18, 2021
welcoMattic
approved these changes
Nov 18, 2021
derrabus
approved these changes
Nov 19, 2021
|
Thank you @xabbuh. |
This was referenced Nov 22, 2021
Merged
Merged
Merged
Merged
xabbuh
referenced
this pull request
in symfony/twig-bridge
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.