Skip to content

add ability to style doubles and integers independently #41962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

add ability to style doubles and integers independently #41962

merged 1 commit into from
Jul 5, 2021

Conversation

1ma
Copy link
Contributor

@1ma 1ma commented Jul 3, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #39393
License MIT

This PR introduces new integer and float keywords, so that clients of the VarDumper component can style both types of variables independently.

Example of the feature in action:
example

Original RFC: #39393

@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Jul 3, 2021
@nicolas-grekas nicolas-grekas changed the title VarDumper: add ability to style doubles and integers independently [VarDumper] add ability to style doubles and integers independently Jul 3, 2021
nicolas-grekas
nicolas-grekas reviewed Jul 3, 2021
View reviewed changes
@carsonbot carsonbot changed the title [VarDumper] add ability to style doubles and integers independently add ability to style doubles and integers independently Jul 5, 2021
@fabpot
Copy link
Member

fabpot commented Jul 5, 2021

Thank you @1ma.

@fabpot fabpot mentioned this pull request Jul 5, 2021
Closed
@fabpot fabpot merged commit fe71423 into symfony:5.4 Jul 5, 2021
@1ma 1ma deleted the issue-39393 branch July 5, 2021 12:35
@1ma 1ma mentioned this pull request Jul 10, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

+1 more reviewer

@ogizanagi ogizanagi ogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[RFC][VarDumper] Add ability to style integer and double values separately
5 participants
@1ma @fabpot @nicolas-grekas @ogizanagi @carsonbot