Skip to content

[Intl] Add Currencies::getCashFractionDigits() and Currencies::getCashRoundingIncrement() #40257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2021
Merged

[Intl] Add Currencies::getCashFractionDigits() and Currencies::getCashRoundingIncrement() #40257

merged 1 commit into from
Feb 19, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #21247
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Feb 19, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 19, 2021
Closed
@stof
Copy link
Member

stof commented Feb 19, 2021

should we have tests covering this code path ?

@nicolas-grekas
Copy link
Member Author

Honestly, I'm doing this for the record... It'd better not spend more time on it...

@nicolas-grekas nicolas-grekas merged commit 5cfe73d into symfony:5.x Feb 19, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 19, 2021
Closed
@nicolas-grekas nicolas-grekas deleted the intl-cash branch February 19, 2021 19:02
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Feature Intl Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

CurrencyBundle::getRoundingIncrement() always retruns 0
4 participants
@nicolas-grekas @stof @javiereguiluz @carsonbot