Skip to content

[PasswordHasher] Use bcrypt as default hash algorithm for "native" and "auto" #40176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2021
Merged

[PasswordHasher] Use bcrypt as default hash algorithm for "native" and "auto" #40176

merged 1 commit into from
Feb 14, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Feb 13, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

As suggested in #39802 (comment), based on https://twitter.com/TerahashCorp/status/1155129705034653698

@chalasr
Copy link
Member Author

chalasr commented Feb 13, 2021

Fabbot failures look like false positives

@chalasr chalasr force-pushed the bcrypt-default branch 2 times, most recently from 20bc2c2 to 3527909 Compare February 14, 2021 12:14
wouterj
wouterj requested changes Feb 14, 2021
View reviewed changes
@chalasr chalasr force-pushed the bcrypt-default branch 2 times, most recently from 08f0035 to f4c1262 Compare February 14, 2021 12:32
@wouterj
Copy link
Member

wouterj commented Feb 14, 2021

Fabbot failures look like false positives

The '\LogicException' seems correct. The exception message false positives are fixed by using concatenation instead (which is done in many places where this caused an issue).

Status: Reviewed 👍

@chalasr
Copy link
Member Author

chalasr commented Feb 14, 2021

Fabbot fixed. Thanks for your reviews Wouter!

@chalasr chalasr merged commit 702a3ee into symfony:5.x Feb 14, 2021
@chalasr chalasr mentioned this pull request Feb 14, 2021
Closed
@chalasr chalasr deleted the bcrypt-default branch February 14, 2021 14:06
@chalasr chalasr added this to the 5.x milestone Feb 14, 2021
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
@chalasr chalasr mentioned this pull request May 22, 2021
Closed
@chalasr chalasr mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Feature PasswordHasher Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @wouterj @fabpot @carsonbot