Skip to content

Conversation

starred-gijs
Copy link
Contributor

@starred-gijs starred-gijs commented Jan 14, 2021

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39837
License MIT

When you want the AmazonSqs transport to create the queue on the fly and you have a fifo queue, the parameters are wrong, and a regular queue is created. This PR fixes the parameters.

@starred-gijs starred-gijs requested a review from sroze as a code owner January 14, 2021 15:58
@carsonbot carsonbot changed the title [Messenger][AmazonSqs] Fix auto-setup for fifo queue [Messenger] [AmazonSqs] Fix auto-setup for fifo queue Jan 14, 2021
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@nicolas-grekas
Copy link
Member

Thank you @starred-gijs.

@nicolas-grekas nicolas-grekas merged commit 402a800 into symfony:5.1 Jan 15, 2021
@starred-gijs starred-gijs deleted the ticket_39837 branch January 15, 2021 10:13
This was referenced Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger][AmazonSqs] Auto-setup does not work for fifo queues
4 participants