Skip to content

[Messenger] Deprecate option prefetch_count #39660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

[Messenger] Deprecate option prefetch_count #39660

merged 1 commit into from
Jan 2, 2021

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? yesno
Tickets -
License MIT
Doc PR -

Revert #30671

@jderusse jderusse requested a review from sroze as a code owner December 29, 2020 20:58
@jderusse jderusse mentioned this pull request Dec 29, 2020
Merged
@jderusse jderusse added this to the 5.x milestone Dec 29, 2020
@carsonbot carsonbot changed the title Deprecate option prefetch_count [Messenger] Deprecate option prefetch_count Dec 30, 2020
chalasr
chalasr reviewed Dec 30, 2020
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Jan 1, 2021

Looks like there is a problem with this PR ("This commit does not belong to any branch on this repository."). Can you rebase please?

xabbuh
xabbuh approved these changes Jan 1, 2021
View reviewed changes
@jderusse jderusse force-pushed the revert-30671 branch 2 times, most recently from ee6639f to 050bc70 Compare January 2, 2021 20:27
@chalasr
Copy link
Member

chalasr commented Jan 2, 2021

Thank you @jderusse.

@chalasr chalasr mentioned this pull request Jan 2, 2021
Closed
@chalasr chalasr merged commit 9cb88fe into symfony:5.x Jan 2, 2021
@jderusse jderusse deleted the revert-30671 branch January 2, 2021 22:22
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Deprecation Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jderusse @fabpot @chalasr @xabbuh @carsonbot