Skip to content

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Dec 28, 2020

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

PhpUnitBridge 5.3 requires PHPUnit 7.5 or later. This PR proposes to remove all polyfilled methods that already exist in PHPUnit 7.5 because they're essentially dead code.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
(this is not a new feature though :) )

@derrabus
Copy link
Member Author

(this is not a new feature though :) )

Right. It's late already and I mixed up the table rows bugfix/feature. 😉

@derrabus derrabus added Bug and removed Feature labels Dec 28, 2020
@fabpot
Copy link
Member

fabpot commented Dec 29, 2020

Thank you @derrabus.

@fabpot fabpot merged commit df5dcc3 into symfony:5.x Dec 29, 2020
@derrabus derrabus deleted the improvement/phpunit-obsolete-polyfills branch December 29, 2020 11:17
@fabpot fabpot mentioned this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants