Skip to content

[Notifier] [Zulip] Host is required #39547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Notifier] [Zulip] Host is required #39547

wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Dec 18, 2020 •
edited
Loading

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR ---

This bridge is the only one right now which cannot use default as host in the DSN, otherwise it would fall back to:

symfony/src/Symfony/Component/Notifier/Transport/AbstractTransport.php

Line 30 in 090b425

protected const HOST = 'localhost';

it could also not use:

symfony/src/Symfony/Component/Notifier/Transport/AbstractTransport.php

Lines 83 to 86 in 090b425

protected function getEndpoint(): ?string
{
return ($this->host ?: $this->getDefaultHost()).($this->port ? ':'.$this->port : '');
}

Based on the documentation you must use your specific url like:
POST https://yourZulipDomain.zulipchat.com/api/v1/messages

Using localhost would have weird side-effects.

Can you confirm this @phpfour , as you provided the bridge?

Todos after merge

  • adjust recipes with new DSN
  • update the docs

@carsonbot carsonbot added this to the 5.2 milestone Dec 18, 2020
@carsonbot carsonbot changed the title [Notifier][Zulip] Host is required [Notifier] [Zulip] Host is required Dec 18, 2020
@jderusse jderusse mentioned this pull request Dec 18, 2020
Merged
2 tasks
@OskarStark OskarStark closed this Dec 18, 2020
@OskarStark OskarStark deleted the fix-zulip-host-5.2 branch December 18, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Notifier Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @carsonbot