Skip to content

[HttpClient] throw clearer error when no scheme is provided #39286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2020
Merged

[HttpClient] throw clearer error when no scheme is provided #39286

merged 1 commit into from
Dec 5, 2020

Conversation

BackEndTea
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39285
License MIT
Doc PR N/A

This could be considred a BC break, as previously this would've a TransportExcepiton, instead of an InvalidArgumentException. But i see no reason to catch this specific error, as it would generally be a configuration error.

@carsonbot carsonbot added this to the 4.4 milestone Dec 2, 2020
@BackEndTea BackEndTea changed the title Bugfix/http client/no scheme Bugfix: throw clearer error when no scheme is provided Dec 2, 2020
@carsonbot carsonbot changed the title Bugfix: throw clearer error when no scheme is provided [HttpClient] Bugfix: throw clearer error when no scheme is provided Dec 2, 2020
@derrabus derrabus added the DX DX = Developer eXperience (anything that improves the experience of using Symfony) label Dec 2, 2020
@derrabus
Copy link
Member

derrabus commented Dec 2, 2020

Looks reasonable to me. Let's see what @nicolas-grekas thinks about this.

nicolas-grekas
nicolas-grekas reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, here are some comments.

@nicolas-grekas nicolas-grekas changed the title [HttpClient] Bugfix: throw clearer error when no scheme is provided [HttpClient] throw clearer error when no scheme is provided Dec 2, 2020
derrabus
derrabus reviewed Dec 2, 2020
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Dec 5, 2020

Thank you @BackEndTea.

@fabpot fabpot force-pushed the bugfix/http-client/no-scheme branch from 47c7c63 to 4d821d6 Compare December 5, 2020 06:03
@fabpot fabpot merged commit 1177baa into symfony:4.4 Dec 5, 2020
@BackEndTea
Copy link
Contributor Author

Thank you @derrabus , @nicolas-grekas & @fabpot

@BackEndTea BackEndTea deleted the bugfix/http-client/no-scheme branch December 6, 2020 14:16
This was referenced Dec 18, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug DX DX = Developer eXperience (anything that improves the experience of using Symfony) HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@BackEndTea @derrabus @fabpot @nicolas-grekas @jderusse @carsonbot