Skip to content

[EventDispatcher] drop logger mock in favor of using the BufferingLogger #38233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

[EventDispatcher] drop logger mock in favor of using the BufferingLogger #38233

merged 1 commit into from
Sep 18, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 18, 2020

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37808 (comment)
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Sep 18, 2020
nicolas-grekas
nicolas-grekas approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(once confirmed green)

@xabbuh xabbuh force-pushed the pr-37808-buffering-logger branch from 397c231 to 86a7e32 Compare September 18, 2020 12:06
@xabbuh xabbuh marked this pull request as ready for review September 18, 2020 12:13
@fabpot
Copy link
Member

fabpot commented Sep 18, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit da644e6 into symfony:3.4 Sep 18, 2020
@xabbuh xabbuh deleted the pr-37808-buffering-logger branch September 18, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
EventDispatcher Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @nicolas-grekas @carsonbot