[HttpClient] Allow to provide additional curl options to CurlHttpClient #38026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Sep 2, 2020
ro0NL
reviewed
Sep 2, 2020
|
Rebased and introduced some checks before options merge. |
nicolas-grekas
approved these changes
Sep 10, 2020
|
Thank you @pizzaminded. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 12, 2020
…ent section (pizzaminded) This PR was squashed before being merged into the master branch. Discussion ---------- [HttpClient] Providing additional options to CurlHttpClient section Documentation for symfony/symfony#38026 PR. Commits ------- 729c7df [HttpClient] Providing additional options to CurlHttpClient section
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagging as a draft because:there is no Doc PR Ready yetThis PR introduces an option to override default curl options defined in
CurlHttpClient. To override them, there is a special place in$optionsprovided:This feature is available only in
CurlHttpClientand would be ignored in another clients.