Skip to content

[Form] silently ignore uninitialized properties when mapping data to forms #37520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

[Form] silently ignore uninitialized properties when mapping data to forms #37520

merged 1 commit into from
Jul 9, 2020
+74 −5

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 8, 2020 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36492
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jul 8, 2020
@xabbuh xabbuh force-pushed the pr-36492 branch 2 times, most recently from c59889e to 27cec90 Compare July 8, 2020 06:53
@lucasmezencio
Copy link

Please, this PR must be accepted! 🙏

@xabbuh xabbuh changed the base branch from master to 3.4 July 8, 2020 10:40
@xabbuh xabbuh marked this pull request as ready for review July 8, 2020 10:52
@xabbuh xabbuh mentioned this pull request Jul 8, 2020
Closed
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 6bfdb92 into symfony:3.4 Jul 9, 2020
@xabbuh xabbuh deleted the pr-36492 branch July 9, 2020 18:45
@lucasmezencio
Copy link

Guys, when is this going to be on 5.1?

@xabbuh
Copy link
Member Author

xabbuh commented Jul 17, 2020

patch releases are published roughly every four weeks

@chypriote
Copy link

Hello @xabbuh, am I right in thinking that this PR will allow the code described here to function ? #36051

Thanks !

@xabbuh
Copy link
Member Author

xabbuh commented Jul 22, 2020

@chypriote yes, it should

@chypriote
Copy link

Nice, thanks for your work :)

This was referenced Jul 24, 2020
Merged
Merged
Merged
Merged
@MatTheCat MatTheCat mentioned this pull request Sep 6, 2021
Closed
@filiplikavcan filiplikavcan mentioned this pull request Dec 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @lucasmezencio @nicolas-grekas @chypriote @yceruto @carsonbot @ph-fritsche