Skip to content

[ErrorHandler] fix setting $trace to null in FatalError #36993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

[ErrorHandler] fix setting $trace to null in FatalError #36993

merged 1 commit into from
May 28, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted by @nikic in php/php-src#5620 (comment)

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 28, 2020
@derrabus
Copy link
Member

derrabus commented May 28, 2020 •
edited
Loading

That'll work, but since it's the second time that we have special handling for $trace === null here, I'd suggest to deal with this case at the very beginning of the method.

edit: Nevermind, $trace = null in fact does something else than $trace = [].

@nicolas-grekas nicolas-grekas merged commit 0d2bc7b into symfony:4.4 May 28, 2020
@nicolas-grekas nicolas-grekas deleted the eh-trace-fix branch May 28, 2020 12:24
This was referenced May 31, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug ErrorHandler Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @derrabus @chalasr @carsonbot