Skip to content

[HttpClient] Adjust AmpResponse to the stricter trait handling in php 8 #36935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

[HttpClient] Adjust AmpResponse to the stricter trait handling in php 8 #36935

merged 1 commit into from
May 24, 2020

Conversation

derrabus
Copy link
Member

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

Follows #36908.

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone May 24, 2020
@nicolas-grekas nicolas-grekas changed the base branch from master to 5.1 May 24, 2020 09:28
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 4488c30 into symfony:5.1 May 24, 2020
@derrabus derrabus deleted the bugfix/amp-response-trait branch May 24, 2020 09:56
@fabpot fabpot mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot