Skip to content

[Form] deprecate NumberToLocalizedStringTransformer::ROUND_* constants #36711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

[Form] deprecate NumberToLocalizedStringTransformer::ROUND_* constants #36711

merged 1 commit into from
May 5, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

To be considered for 5.1 before introducing the consts on PercentToLocalizedStringTransformer.

@nicolas-grekas nicolas-grekas added this to the 5.1 milestone May 5, 2020
@nicolas-grekas nicolas-grekas requested a review from xabbuh as a code owner May 5, 2020 15:24
@nicolas-grekas nicolas-grekas force-pushed the round branch 5 times, most recently from 40f5060 to 9511cc9 Compare May 5, 2020 15:43
@fabpot
Copy link
Member

fabpot commented May 5, 2020

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request May 5, 2020
Closed
@fabpot fabpot merged commit 4dbf987 into symfony:master May 5, 2020
@nicolas-grekas nicolas-grekas deleted the round branch May 5, 2020 16:56
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @carsonbot