improve upgrade instructions for twig.exception_controller configuration #34519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Nov 22, 2019
👍 fixed |
yceruto
approved these changes
Nov 22, 2019
yceruto
reviewed
Nov 22, 2019
as discussed, it's already there 👍 |
|
Thank you @bendavies. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…er configuration (bendavies) This PR was merged into the 4.4 branch. Discussion ---------- improve upgrade instructions for twig.exception_controller configuration | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This improves the upgrade instructions for the deprecated configuration of `twig.exception_controller`. Or would it be better to make the default `null` on 4.4? https://github.com/symfony/symfony/blob/a8a9e69488fdaf609fecacba66e056ffb8f25da8/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L41 Commits ------- bdc68fd improve upgrade instructions for twig.exception_controller configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the upgrade instructions for the deprecated configuration of
twig.exception_controller.Or would it be better to make the default
nullon 4.4?symfony/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php
Line 41 in a8a9e69