[Validator][DX] Add isEmpty() method to ConstraintViolationListInterface #32733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jul 27, 2019
yceruto
reviewed
Jul 29, 2019
785ca88 to
2e004f7
Compare
OskarStark
approved these changes
Jul 31, 2019
yceruto
reviewed
Jul 31, 2019
src/Symfony/Component/Validator/ConstraintViolationListInterface.php
Outdated
Show resolved
Hide resolved
2e004f7 to
7fec655
Compare
yceruto
approved these changes
Jul 31, 2019
|
I'm challenging this: this is the same as |
|
Let's close. If we add it here, we will have to add it on every collection that have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to improve the DX (a little) with constraint violation lists.
I always find myself doing :
if ($constraintViolationList->count() > 0)orif (0 === $constraintViolationList->count())It would be nice if we could do :
if (!$constraintViolationList->isEmpty())orif ($constraintViolationList->isEmpty())hasViolations()could be an alternative name butisEmpty()is a common name used in many places in Sf code, so it seems more logical to me.