Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)" #29720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Dec 28, 2018
nicolas-grekas
approved these changes
Jan 3, 2019
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 3, 2019
…(ro0NL)" (chalasr) This PR was merged into the 4.2 branch. Discussion ---------- Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)" | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Intl is an hard dependency for Form, these checks cannot be reached. Commits ------- 3ac98a6 Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)"
1 task
fabpot
added a commit
that referenced
this pull request
Feb 25, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Form] Remove hard dependency on symfony/intl | Q | A | ------------- | --- | Branch? | 5.x (or 6.0) | Bug fix? | | New feature? | no | Deprecations? | yes | Tickets | Fix #39596 | License | MIT | Doc PR | symfony/symfony-docs#15026 This was voted down in 2018 (#29229) and will revert #29720 by @chalasr. I reopen it because the Form component is way less dependent on Intl component now. Im hesitant if we should do this in 5.x or 6.0. If a user don't have `symfony/intl` installed, they will get an error in runtime. That is something that speaks for doing it in 6.0. Could I get some opinions? ### TODO - [x] Update `UPGRADE-x.x.md` Commits ------- f90d3ec [Form] Remove hard dependency on symfony/intl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intl is an hard dependency for Form, these checks cannot be reached.