Skip to content

Respect alpha order in UPGRADE-4.2 file #27781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2018
Merged

Respect alpha order in UPGRADE-4.2 file #27781

merged 1 commit into from
Jun 30, 2018

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request Jun 30, 2018
Merged
@fabpot
Copy link
Member

fabpot commented Jun 30, 2018

Good catch, thanks @ogizanagi.

@fabpot fabpot merged commit d5c1cc0 into symfony:master Jun 30, 2018
fabpot added a commit that referenced this pull request Jun 30, 2018
@fabpot
minor #27781 Respect alpha order in UPGRADE-4.2 file (ogizanagi)
03de7f4 
This PR was merged into the 4.2-dev branch.

Discussion
----------

Respect alpha order in UPGRADE-4.2 file

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

d5c1cc0 Respect alpha order in UPGRADE-4.2 file
@ogizanagi ogizanagi deleted the upgrade-4.2/alpha-order branch June 30, 2018 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

+1 more reviewer

@sroze sroze sroze approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogizanagi @fabpot @sroze @carsonbot