Skip to content

Conversation

kbond
Copy link
Member

@kbond kbond commented Oct 27, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23451 (comment)
License MIT
Doc PR n/a

#23624 broke #23451.

Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 28, 2017
@nicolas-grekas
Copy link
Member

Good catch, thanks @kbond.

@nicolas-grekas nicolas-grekas merged commit 14c62da into symfony:3.4 Oct 28, 2017
nicolas-grekas added a commit that referenced this pull request Oct 28, 2017
…ommand service id (kbond)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] fix CachePoolPrunerPass to use correct command service id

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23451 (comment)
| License       | MIT
| Doc PR        | n/a

#23624 broke #23451.

Commits
-------

14c62da fix CachePoolPrunerPass to use correct command service id
This was referenced Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants