Skip to content

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Sep 22, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets complete #23694
License MIT
Doc PR N/A

Just completing tests a bit for this new feature. cc @yceruto

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ogizanagi
Copy link
Contributor Author

@yceruto : I've added the missing line break 😉

@yceruto
Copy link
Member

yceruto commented Sep 22, 2017

Yep, me too https://github.com/symfony/symfony/pull/24208/files#diff-e309bf8cabe506cd529bbeb259f2ae6eR169 the first to merge resolves the conflict 😄

@ogizanagi ogizanagi merged commit 35f9c0b into symfony:3.4 Sep 22, 2017
ogizanagi added a commit that referenced this pull request Sep 22, 2017
…nagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add ambiguous & exception debug:form tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | complete #23694  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Just completing tests a bit for this new feature. cc @yceruto

Commits
-------

35f9c0b [Form] Add ambiguous & exception debug:form tests
@ogizanagi ogizanagi deleted the form/more_debug_tests branch September 22, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants