Added an alias for FlashBagInterface in config #24200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tifabien
commented
Sep 14, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
nicolas-grekas
approved these changes
Sep 16, 2017
|
Somewhat related: #11279 and co |
|
Regarding #11279, would it make sense to make this service available in AbstractController? (could be for another PR) |
|
@chalasr in practice a |
|
Indeed! |
chalasr
approved these changes
Sep 19, 2017
|
Do I need to rebase my branch on top of 3.4 or is it not necessary? |
|
Thank you @tifabien. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 26, 2017
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #24200). Discussion ---------- Added an alias for FlashBagInterface in config | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- b6b6d31 Added an alias for FlashBagInterface in config
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.