[DI] rename ResolveDefinitionTemplatesPass to ResolveChildDefinitionsPass #24122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ec55f to
01097f2
Compare
01097f2 to
a7f98c6
Compare
chalasr
approved these changes
Sep 7, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2017
…hildDefinitionsPass (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] rename ResolveDefinitionTemplatesPass to ResolveChildDefinitionsPass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Because that name makes things harder to understand now. This uses exactly the same BC layer logic as the one we have for the renaming of DefinitionDecorator to ChildDefinition. Commits ------- a7f98c6 [DI] rename ResolveDefinitionTemplatesPass to ResolveChildDefinitionsPass
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because that name makes things harder to understand now.
This uses exactly the same BC layer logic as the one we have for the renaming of DefinitionDecorator to ChildDefinition.