Skip to content

[Yaml] Suggest using quotes instead of Yaml::PARSE_KEYS_AS_STRINGS #23635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2017
Merged

[Yaml] Suggest using quotes instead of Yaml::PARSE_KEYS_AS_STRINGS #23635

merged 1 commit into from
Jul 24, 2017

Conversation

GuilhemN
Copy link
Contributor

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR https://github.com/symfony/symfony/pull/22948/files#r126940623

@GuilhemN GuilhemN changed the base branch from master to 3.3 July 23, 2017 12:43
@GuilhemN GuilhemN changed the title Bcmessage [Yaml] Suggest using quotes instead of Yaml::PARSE_KEYS_AS_STRINGS Jul 23, 2017
@GuilhemN GuilhemN mentioned this pull request Jul 23, 2017
Closed
@xabbuh xabbuh added this to the 3.3 milestone Jul 24, 2017
@xabbuh xabbuh added the Yaml label Jul 24, 2017
@fabpot
Copy link
Member

fabpot commented Jul 24, 2017

Thank you @GuilhemN.

@fabpot fabpot merged commit 9fd425e into symfony:3.3 Jul 24, 2017
fabpot added a commit that referenced this pull request Jul 24, 2017
@fabpot
minor #23635 [Yaml] Suggest using quotes instead of Yaml::PARSE_KEYS_…
a00b05e 
…AS_STRINGS (GuilhemN)

This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] Suggest using quotes instead of Yaml::PARSE_KEYS_AS_STRINGS

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony/pull/22948/files#r126940623

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the 3.4,
  legacy code removals go to the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

9fd425e Suggest using quotes instead of Yaml::PARSE_KEYS_AS_STRINGS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Needs Review Yaml
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@GuilhemN @fabpot @nicolas-grekas @xabbuh @carsonbot