Fix case sensitive sameSite cookie #23586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikefrancis
commented
Jul 19, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23585 |
| License | MIT |
| Doc PR |
|
Cant/shouldnt we patch this in Doing it in __construct doesnt sound right to me. Then again, this is defined per spec... fine either way i guess. 👍 |
ro0NL
approved these changes
Jul 19, 2017
aidantwoods
approved these changes
Jul 19, 2017
fabpot
approved these changes
Jul 20, 2017
javiereguiluz
approved these changes
Jul 20, 2017
|
Thank you @mikefrancis. |
fabpot
added a commit
that referenced
this pull request
Jul 20, 2017
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #23586). Discussion ---------- Fix case sensitive sameSite cookie | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23585 | License | MIT | Doc PR | Commits ------- 14c310f Fix case sensitive sameSite cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.