Skip to content

[DependencyInjection] Decorating service should inherit autowire from decorated #20280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DependencyInjection] Decorating service should inherit autowire from decorated #20280

wants to merge 1 commit into from

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Oct 23, 2016 •
edited
Loading

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Same as #19643 for decoration.

ping @dunglas

@chalasr chalasr changed the base branch from master to 2.8 October 23, 2016 09:37
@chalasr chalasr force-pushed the fix/decorating_inherit_decorated_autowire branch from 1ff8d50 to 3c6004d Compare October 23, 2016 09:37
@chalasr
Copy link
Member Author

chalasr commented Oct 23, 2016

I'm not sure of this patch, it involves that the decorating can't override the autowire value. Maybe we should let it as is?

@chalasr
Copy link
Member Author

chalasr commented Oct 23, 2016

Closing as it behaves better as it is.

@chalasr chalasr closed this Oct 23, 2016
@chalasr chalasr deleted the fix/decorating_inherit_decorated_autowire branch May 10, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalasr @carsonbot