[Console] Fix validation of empty values using SymfonyQuestionHelper::ask() #20141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
QuestionHelper::ask()
it's allowed to return an empty value as answer, e.g:Just typing
enter
for answering this question works, the value of$answer
would befalse
.But doing the same with
SymfonyQuestionHelper::ask()
:Same for
''
ornull
.Here I kept the same check but used as default validator, if a validator is set and allows an empty value to be returned then it's ok.
Also I am not sure about if this default validator should be kept, imho we should be consistent with the default question helper, using the
SymfonyQuestionHelper
should only impact the output.Diff best viewed like this
ping @kbond