Skip to content

[Process] Fix write access check for pipes on Windows #19427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Process] Fix write access check for pipes on Windows #19427

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jul 25, 2016 •
edited
Loading

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19336, #19416
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas mentioned this pull request Jul 25, 2016
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 25, 2016
Closed
@fernandobandeira
Copy link

fernandobandeira commented Jul 26, 2016 •
edited
Loading

Confirmed fixed #19416, still it is throwing a warning with xdebug enabled, the full stacktrace is on the issue. I don't mind having the warning but would be nice to properly handle the unlink exception in the future.

Also this could go to 3.0 instead of 3.1 IMO

@nicolas-grekas
Copy link
Member Author

Reopening on 2.7

@nicolas-grekas nicolas-grekas deleted the fix-19416-win-pipes branch July 26, 2016 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Process Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fernandobandeira @carsonbot