[Console] removed unneeded private methods #19163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jun 24, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | https://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709 |
| License | MIT |
| Doc PR | n/a |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Console] removed unneeded private methods | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709 | License | MIT | Doc PR | n/a Commits ------- 35f32eb [Console] removed unneeded private methods
|
OOI, why not have this as a local static? It really is only of use in this 1 method (and was were I placed it originally) :-D |
|
Method static vars are shared by all instances of a class so it wouldn't work here. |
|
Of course they are! (Hangs head in shame!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.