Skip to content

Conversation

tgalopin
Copy link
Contributor

@tgalopin tgalopin commented Jan 6, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:

  • phpunit -c app
  • phpunit --configuration app
  • phpunit --configuration=app

But it fails with the synthax phpunit -capp, even if PHPUnit supports it. This PR fixes this.

See #17272.

@tgalopin tgalopin changed the title [FrameworkBundle] Add case in Kernel directory guess for PHPUnit [2.7][FrameworkBundle] Add case in Kernel directory guess for PHPUnit Jan 6, 2016
@xabbuh
Copy link
Member

xabbuh commented Jan 6, 2016

👍

@fabpot
Copy link
Member

fabpot commented Jan 7, 2016

Thank you @tgalopin.

@fabpot fabpot merged commit a7b7766 into symfony:2.7 Jan 7, 2016
fabpot added a commit that referenced this pull request Jan 7, 2016
…for PHPUnit (tgalopin)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7][FrameworkBundle] Add case in Kernel directory guess for PHPUnit

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:

- `phpunit -c app`
- `phpunit --configuration app`
- `phpunit --configuration=app`

But it fails with the synthax `phpunit -capp`, even if PHPUnit supports it. This PR fixes this.

See #17272.

Commits
-------

a7b7766 [FrameworkBundle] Add case in Kernel directory guess for PHPUnit
This was referenced Jan 14, 2016
@fabpot fabpot mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants