Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.4
Choose a base ref
...
head repository: symfony/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.4
Choose a head ref
  • 8 commits
  • 9 files changed
  • 5 contributors

Commits on Aug 21, 2025

  1. Configuration menu
    Copy the full SHA
    5c4618c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76a0379 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2025

  1. feature #61486 [Security] Ignore target route when exiting impersonat…

    …ion (MatTheCat)
    
    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [Security] Ignore target route when exiting impersonation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #53873
    | License       | MIT
    
    [The user impersonation documentation](https://symfony.com/doc/current/security/impersonating_user.html#redirecting-to-a-specific-target-route) just mentions
    
    > control the redirection target route via `target_route`
    
    Now, given that Twig’s `impersonation_exit_path` and `impersonation_exit_url` have an `exitTo` parameter but not `impersonation_path` nor `impersonation_url`, it looks like `target_route` should only be used when **starting** an impersonation. However it is currently also used when exiting, which means that if you configured one, an `exitTo` argument wouldn’t have any effect.
    
    Based on this assumption, this PR ignores `target_route` when exiting impersonation.
    
    Since `exitTo` will now work with `target_route` this PR technically breaks BC, but since this behavior was broken I’m not sure it needs to be considered.
    
    Commits
    -------
    
    5c4618c [Security] Ignore target route when exiting impersonation
    fabpot committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    a410ac7 View commit details
    Browse the repository at this point in the history
  2. minor #61495 [Security][Validator] Review translations (yurguis)

    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [Security][Validator] Review translations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #54958
    | License       | MIT
    
    Commits
    -------
    
    76a0379 [Security][Validator] Review translations.
    nicolas-grekas committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    1cf3e65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b08751e View commit details
    Browse the repository at this point in the history
  4. [String] Fix nodes singular

    Before it would suggest nod. It should be node.
    ruudk committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    6042ede View commit details
    Browse the repository at this point in the history
  5. bug #61503 [String] Fix nodes singular (ruudk)

    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [String] Fix nodes singular
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        |
    | License       | MIT
    
    Before it would suggest nod. It should be node.
    
    Commits
    -------
    
    6042ede [String] Fix nodes singular
    nicolas-grekas committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    5b9a1fe View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2025

  1. bug #61501 [Console] Fix testing multiline question (MatTheCat)

    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [Console] Fix testing multiline question
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #58910
    | License       | MIT
    
    Commits
    -------
    
    b08751e [Console] Fix testing multiline question
    fabpot committed Aug 23, 2025
    Configuration menu
    Copy the full SHA
    5c143ba View commit details
    Browse the repository at this point in the history
Loading