Skip to content

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Nov 1, 2021

No description provided.

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Nov 2, 2021
…e (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] Fix `Request::getUserInfo()` return type

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This method delegates to `getUser()` which itself can return `null`. It feels better than an empty string to me, and it's always been the case.
Spotted in symfony/psr-http-message-bridge#100

Commits
-------

65edf9e Fix `Request::getUserInfo()` return type
@chalasr chalasr merged commit c81476c into main Nov 5, 2021
@chalasr chalasr deleted the sf-6 branch November 5, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants