Skip to content

Fix Package.swift warning by excluding JavaScript files #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2025
Merged

Fix Package.swift warning by excluding JavaScript files #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
078f456
Fix Package.swift warning by excluding JavaScript files
kateinoigakukun Aug 16, 2025
218d2df
Format Swift code
kateinoigakukun Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Plugins/BridgeJS/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ let package = Package(
dependencies: [
"BridgeJSCore",
"BridgeJSSkeleton",
]
],
exclude: ["JavaScript"]
),
.target(
name: "BridgeJSCore",
Expand Down
10 changes: 8 additions & 2 deletions Plugins/PackageToJS/Tests/ExampleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,10 @@ extension Trait where Self == ConditionTrait {
try scriptContent.write(to: tempDir.appending(path: "script.js"), atomically: true, encoding: .utf8)
let scriptPath = tempDir.appending(path: "script.js")
try runSwift(
["package", "--disable-sandbox", "--swift-sdk", swiftSDKID, "js", "test", "-Xnode=--require=\(scriptPath.path)"],
[
"package", "--disable-sandbox", "--swift-sdk", swiftSDKID, "js", "test",
"-Xnode=--require=\(scriptPath.path)",
],
[:]
)
let testPath = tempDir.appending(path: "test.txt")
Expand All @@ -265,7 +268,10 @@ extension Trait where Self == ConditionTrait {
"test.txt should be created by the script"
)
})
try runSwift(["package", "--disable-sandbox", "--swift-sdk", swiftSDKID, "js", "test", "--environment", "browser"], [:])
try runSwift(
["package", "--disable-sandbox", "--swift-sdk", swiftSDKID, "js", "test", "--environment", "browser"],
[:]
)
}
}

Expand Down