Fix MCCAS issue with LEB and CVInline Fragments. #11224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to write a test for it? |
|
@cachemeifyoucan I don't know how to generate an .ll file where it guarantees that the MCAssembler will contain an FT_LEB fragment and/or a FT_CVInlineLines fragment. Only thing I can think of is reducing the testcase that broke with delta and llvm-reduce to get something smaller. I can do that |
The 2100 branch took a snapshot of MC changes which reclassified LEB and CVInline fragments as Encoded Fragments. We need to add support for serializing both these fragment types in MCDataFragmentMerger::emitMergedFragments. This patch accomplishes that task. rdar://157494251
19eabf7 to
2ba5cda
Compare
|
@cachemeifyoucan test added! |
|
Remember to migrate test into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2100 branch took a snapshot of MC changes which reclassified LEB and CVInline fragments as Encoded Fragments. We need to add support for serializing both these fragment types in
MCDataFragmentMerger::emitMergedFragments. This patch accomplishes that task.
rdar://157494251