[IncludeTree] Do not pass compilation directories #11034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
commented
Jul 21, 2025
3f1d9a9 to
a1a7393
Compare
|
@swift-ci please test llvm |
1 similar comment
|
@swift-ci please test llvm |
|
ping |
1 similar comment
|
ping |
|
@adrian-prantl can you confirm this is okay? It's fine from my perspective. |
|
This is a follow up for llvm#150112 to avoid passing compilation directory for modules (and for include-tree, that is everything) |
When using include-tree, all the relative paths references should be turned into absolute path already. There is no need to pass options like `-fdebug-compilation-dir` for debug info generation as it makes cache hit less likely when two identical compilations where performed with different compilation directories.
a1a7393 to
5f0e8d7
Compare
|
@swift-ci please test llvm |
| @@ -21,7 +23,9 @@ | |||
| // RUN: %clang @%t/tu.rsp | |||
|
|
|||
| // RUN: cat %t/tu.ll | FileCheck %s -check-prefix=LLVMIR -DPREFIX=%/t | |||
| // LLVMIR: !DICompileUnit({{.*}}, splitDebugFilename: "prefix.pch" | |||
| // LLVMIR: !DIFile(filename: "[[PREFIX]]/tu.c", directory: "") | |||
There was a problem hiding this comment.
where is the PREFIX FileCheck variable initialized?
There was a problem hiding this comment.
would have expected [[PREFIX:.*]] here
There was a problem hiding this comment.
RUN: cat %t/tu.ll | FileCheck %s -check-prefix=LLVMIR -DPREFIX=%/t It is initialized from the command-line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using include-tree, all the relative paths references should be turned into absolute path already. There is no need to pass options like
-fdebug-compilation-dirfor debug info generation as it makes cache hit less likely when two identical compilations where performed with different compilation directories.