Skip to content

Use StrictConcurrency=complete in Package.swift and add Swift 6 language mode CI #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2024
Merged

Use StrictConcurrency=complete in Package.swift and add Swift 6 language mode CI #44

merged 3 commits into from
Dec 20, 2024

Conversation

simonjbeaumont
Copy link
Collaborator

@simonjbeaumont simonjbeaumont commented Dec 10, 2024 •
edited
Loading

Motivation

We're trying to lock in strict concurrency across the package ecosystem and standardise on how that's tested.

Modifications

  • Add StrictConcurrency=complete feature flag to all targets in the package manifest
  • Remove now superfluous strict concurrency compiler flag in CI runs
  • Add a new CI pipeline that tests the package with Swift 6 language mode.

Result

  • Package configuration consistent with others adopting strict concurrency.
  • Swift 6 language mode pipeline established to catch regressions.

@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label Dec 10, 2024
@simonjbeaumont simonjbeaumont changed the title Sb/strict concurrency Use StrictConcurrency=complete in Package.swift and add Swift 6 language mode CI Dec 10, 2024
@simonjbeaumont simonjbeaumont marked this pull request as ready for review December 10, 2024 09:42
@simonjbeaumont simonjbeaumont enabled auto-merge (squash) December 11, 2024 20:58
@simonjbeaumont simonjbeaumont merged commit fdd7e2f into main Dec 20, 2024
23 checks passed
@simonjbeaumont simonjbeaumont deleted the sb/strict-concurrency branch December 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjbeaumont @czechboy0