Skip to content

Weakly capture the HTTPConnectionPool in the idle connection timeout task #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Weakly capture the HTTPConnectionPool in the idle connection timeout task #853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/AsyncHTTPClient/ConnectionPool/HTTPConnectionPool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,10 @@ final class HTTPConnectionPool:
"ahc-connection-id": "\(connectionID)"
]
)
let scheduled = eventLoop.scheduleTask(in: self.idleConnectionTimeout) {
let scheduled = eventLoop.scheduleTask(in: self.idleConnectionTimeout) { [weak self] in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid the use of a weak reference here: its performance impact will be very substantial.

Instead, so long as all of these tasks are cancelled in the shutdown routine (as they should be), there will be no leak, as the cancellation of the tasks will drop the function reference.

guard let self else {
return
}
// there might be a race between a cancelTimer call and the triggering
// of this scheduled task. both want to acquire the lock
self.modifyStateAndRunActions { stateMachine in
Expand Down
Loading