MP1 update #774
Merged
MP1 update #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
in engineering mode only. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Yes. I tested it. diff --git a/run_arduino_gen.sh b/run_arduino_gen.sh
index 3b67ecba..2704625f 100755
--- a/run_arduino_gen.sh
+++ b/run_arduino_gen.sh
@@ -219,10 +219,11 @@ case "$1" in
TERM=xterm minicom -D $RPMSG_DIR
;;
generate)
- generate_packaged_script $2 $3
- echo "$(readlink -f "$3") generated successfully."
+ output=$(echo "$3" | sed 's/\.ino\././g')
+ generate_packaged_script $2 $output
+ echo "$(readlink -f "$output") generated successfully."
echo "This file should be uploaded manually by SCP, SFTP, Kermit, or etc."
- echo "Then run \"sh ./$(basename $3) start\" command in the board's console."
+ echo "Then run \"sh ./$(basename $output) start\" command in the board's console."
echo "For detailed instructions, please visit:"
echo " https://github.com/stm32duino/Arduino_Core_STM32/tree/master/variants/STM32MP157_DK/README.md"
;;should work, tested in Linux and Windows. |
kbumsik
reviewed
Nov 15, 2019
kbumsik
reviewed
Nov 15, 2019
kbumsik
reviewed
Nov 16, 2019
kbumsik
reviewed
Nov 16, 2019
|
Well, |
Co-Authored-By: Bumsik Kim <k.bumsik@gmail.com> Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
https://github.com/STMicroelectronics/STM32CubeMP1/releases/tag/1.1.1 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
[New variant] STM32MP157_DK #717 (comment)
I will probably also update the generated script name with the sketch name.Done@kbumsik as discussed in stm32duino/Arduino_Tools#47 (comment), do you think it is correct to use sed in the generate part of the script?
Maybe I will add theMP1 Cube update 1.1.1: