Skip to content

chore: address commit comments for commit 1acd7fc (issue #7914) #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

srinivas-batthula
Copy link
Contributor

@srinivas-batthula srinivas-batthula commented Aug 21, 2025

Resolves #7914

Description:
What is the purpose of this pull request?

This pull request updates the example in the JSDoc block of
lib/node_modules/@stdlib/utils/none-own-by/lib/index.js
to follow the suggested object formatting style.

Specifically, the example was changed from:

  • var obj = { a: 10, b: 12, c: 15 };

to:

  • var obj = {
    'a': 10,
    'b': 12,
    'c': 15
    };

Related Issues:
This pull request resolves #7914

Questions:
Any questions for reviewers of this pull request?
No.

Other:
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.

Checklist:
Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Signed-off-by: Srinivas Batthula <srinivasbatthula05.official@gmail.com>
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Aug 21, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Aug 21, 2025

Coverage Report

Package Statements Branches Functions Lines
utils/none-own-by $\color{green}125/125$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}125/125$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Aug 21, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Aug 21, 2025

PR Commit Message

chore: address commit comments for commit `1acd7fc`

PR-URL: https://github.com/stdlib-js/stdlib/pull/7917
Closes: https://github.com/stdlib-js/stdlib/issues/7914

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Srinivas Batthula <srinivasbatthula05.official@gmail.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 21, 2025
@Planeshifter Planeshifter merged commit d2b9b0c into stdlib-js:develop Aug 21, 2025
27 checks passed
@srinivas-batthula srinivas-batthula deleted the fix-example-obj-issue-7914 branch August 22, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 1acd7fc)
3 participants