-
-
Notifications
You must be signed in to change notification settings - Fork 867
chore: address commit comments for commit 1acd7fc (issue #7914) #7917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address commit comments for commit 1acd7fc (issue #7914) #7917
Conversation
Signed-off-by: Srinivas Batthula <srinivasbatthula05.official@gmail.com>
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*" If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #7914
Description:
What is the purpose of this pull request?
This pull request updates the example in the JSDoc block of
lib/node_modules/@stdlib/utils/none-own-by/lib/index.js
to follow the suggested object formatting style.
Specifically, the example was changed from:
to:
'a': 10,
'b': 12,
'c': 15
};
Related Issues:
This pull request resolves #7914
Questions:
Any questions for reviewers of this pull request?
No.
Other:
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist:
Please ensure the following tasks are completed before submitting this pull request.
@stdlib-js/reviewers