chore: code review

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-js · aayush0325 · May 12, 2025 · May 12, 2025 · May 12, 2025 · May 12, 2025
commit c640b9ff8977d4303d894d4a814366fce31f5166
diff --git a/lib/node_modules/@stdlib/lapack/base/dgebal/lib/base.js b/lib/node_modules/@stdlib/lapack/base/dgebal/lib/base.js
@@ -16,7 +16,7 @@
 * limitations under the License.
 */
 
-/* eslint-disable max-len, max-params, max-statements */
+/* eslint-disable max-len, max-params, max-statements, max-lines-per-function */
 
 'use strict';
 
@@ -104,9 +104,14 @@ function dgebal( job, N, A, strideA1, strideA2, offsetA, out, strideOut, offsetO
 	var ia2;
 	var ia3;
 	var ia4;
+	var oa1;
+	var oa2;
+	var oa3;
+	var oa4;
 	var ca;
 	var ra;
 	var is;
+	var os;
 	var c;
 	var r;
 	var k;
@@ -184,15 +189,21 @@ function dgebal( job, N, A, strideA1, strideA2, offsetA, out, strideOut, offsetO
 			}
 		}
 
+		os = offsetScale + ( k * strideScale );
+		oa1 = offsetA + ( k * strideA2 );
+		oa2 = offsetA + ( k * strideA2 );
+		oa3 = offsetA + ( k * strideA1 );
+		oa4 = offsetA + ( k * strideA1 );
+
 		noconv = true;
 		while ( noconv ) {
 			// Search for columns isolating an eigenvalue and push them left
 			noconv = false;
-			is = offsetScale + ( k * strideScale ); // Follows scale
-			ia1 = offsetA + ( k * strideA2 ); // Follows `j`th column of A
-			ia2 = offsetA + ( k * strideA2 ); // Follows `k`th column of A
-			ia3 = offsetA + ( k * strideA1 ); // Follows `j`th row of A
-			ia4 = offsetA + ( k * strideA1 ); // Follows `k`th row of A
+			is = os; // Follows scale
+			ia1 = oa1; // Follows `j`th column of A
+			ia2 = oa2; // Follows `k`th column of A
+			ia3 = oa3; // Follows `j`th row of A
+			ia4 = oa4; // Follows `k`th row of A
 
 			for ( j = k; j <= l; j++ ) {
 				canSwap = true;
@@ -232,13 +243,18 @@ function dgebal( job, N, A, strideA1, strideA2, offsetA, out, strideOut, offsetO
 		return 0;
 	}
 
+	os = offsetScale + ( k * strideScale );
+	oa1 = offsetA + ( k * strideA1 ) + ( k * strideA2 );
+	oa2 = offsetA + ( k * strideA1 ) + ( k * strideA2 );
+	oa3 = offsetA + ( k * strideA2 );
+
 	// Balance the submatrix in rows K to L, iterative loop for norm reduction (job = 'B')
 	noconv = true;
 	while ( noconv ) {
-		is = offsetScale + ( k * strideScale ); // Follows scale
-		ia1 = offsetA + ( k * strideA1 ) + ( k * strideA2 ); // Follows A[ k, i ]
-		ia2 = offsetA + ( k * strideA1 ) + ( k * strideA2 ); // Follows A[ i, k ]
-		ia3 = offsetA + ( k * strideA2 ); // follows `i`th column of A
+		is = os; // Follows scale
+		ia1 = oa1; // Follows A[ k, i ]
+		ia2 = oa2; // Follows A[ i, k ]
+		ia3 = oa3; // follows `i`th column of A
 
 		noconv = false;
 		for ( i = k; i <= l; i++ ) {