Skip to content

Optimizes how rehierarch_from_type_blocks is implemented. Fixes tests. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

chaburkland
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #516 (1b5b515) into master (bce7d60) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master     #516      +/-   ##
===========================================
- Coverage   100.00%   99.70%   -0.30%     
===========================================
  Files           59       57       -2     
  Lines        19874    19728     -146     
===========================================
- Hits         19874    19669     -205     
- Misses           0       59      +59     
Impacted Files Coverage Δ
static_frame/core/container_util.py 99.56% <100.00%> (-0.44%) ⬇️
static_frame/core/display.py 97.59% <0.00%> (-2.41%) ⬇️
static_frame/core/memory_measure.py 98.36% <0.00%> (-1.64%) ⬇️
static_frame/core/www.py 98.57% <0.00%> (-1.43%) ⬇️
static_frame/core/display_config.py 98.70% <0.00%> (-1.30%) ⬇️
static_frame/core/pivot.py 99.04% <0.00%> (-0.96%) ⬇️
static_frame/core/util.py 99.26% <0.00%> (-0.74%) ⬇️
static_frame/core/join.py 99.29% <0.00%> (-0.71%) ⬇️
static_frame/core/node_selector.py 99.29% <0.00%> (-0.71%) ⬇️
static_frame/core/node_str.py 99.31% <0.00%> (-0.69%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chaburkland chaburkland marked this pull request as ready for review July 14, 2022 18:07
Copy link
Contributor

@flexatone flexatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just one suggestion.

@flexatone
Copy link
Contributor

flexatone commented Jul 18, 2022

I now recall that the old behavior, keeping labels in their first-observed order but making them hierarchable (in the old sense) was a feature. I am not sure that global sorting is what we always want to do. Lets consider that before merging this change.

Also: does this approach require labels per depth to be sortable? If the previous approach did not require labels to be sortable, we might prefer it.

@chaburkland
Copy link
Collaborator Author

@flexatone I can't remember what we were doing with this PR. Did we come to any conclusions, namely, either merge, merge with changes, or abandon entirely?

@flexatone
Copy link
Contributor

@chaburkland : As discussed above, I think retaining ordering in rehierarching is important. Does this retain order, or do a full lex sort on all depths?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants