Skip to content

Install SVG logo as hicolor scalable icon #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Install SVG logo as hicolor scalable icon #2431

merged 1 commit into from
Oct 10, 2020

Conversation

pinotree
Copy link
Contributor

Install the SVG logo as scalable icon in the global hicolor icon theme: this way, application launchers/browsers that show icons bigger than 256 pixels can show a good-looking icon from the SVG logo instead of upscaling the 256px PNG icon.

Install the SVG logo as scalable icon in the global hicolor icon theme:
this way, application launchers/browsers that show icons bigger than
256 pixels can show a good-looking icon from the SVG logo instead of
upscaling the 256px PNG icon.
@justinclift
Copy link
Member

Thanks @pinotree, this seems like a good idea. 😄

@justinclift justinclift added the enhancement Feature requests. label Oct 10, 2020
@mgrojo mgrojo merged commit acd23e1 into sqlitebrowser:master Oct 10, 2020
@mgrojo
Copy link
Member

mgrojo commented Oct 10, 2020

Thanks for the contribution, @pinotree!

@pinotree pinotree deleted the install-svg-icon branch October 10, 2020 15:04
@scottfurry
Copy link
Contributor

When we did PR for #2270, we only handled the icon files. The assumption there was that application icon was to be taken from the images folder for both png and svg. I can see now that we overlooked the CMakeLists.txt file. The CMakeLists.txt entry for the png image is not being sourced from the images folder.

Recommend correcting pull to match past assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants