Skip to content

Updates the Brazilian Portuguese files for 3.12.0 #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bernardosulzbach
Copy link
Contributor

Some comments.

  1. See the identical strings (Y1, Y2). Should I leave their translation blank instead?
  2. Several translation strings seem to have quite a bit of HTML (or a subset of HTML) in them. Is this necessary? Couldn't this be moved "away" from the translation files? It doesn't seem to me like something a translator should have access to (if someone changes the markup, even if by accident, this is probably going to cause issues).
  3. I think the <li> "Login to the dbhub.io website (use your GitHub credentials or whatever you want)" is missing a period at the end (or the other <li>s should lose theirs for consistency). I did not add this period in their Portuguese translation, so if you change the source, just throw a period into the Portuguese translation too, please.

@mgrojo
Copy link
Member

mgrojo commented Jun 9, 2020

Some comments.

  1. See the identical strings (Y1, Y2). Should I leave their translation blank instead?

I think the result is the same, so it's up to you. Maybe these cases are never translated, I can only think of languages with script different to Latin, but then mathematics is a universal language, so I don't know. Better to give the opportunity.

  1. Several translation strings seem to have quite a bit of HTML (or a subset of HTML) in them. Is this necessary? Couldn't this be moved "away" from the translation files? It doesn't seem to me like something a translator should have access to (if someone changes the markup, even if by accident, this is probably going to cause issues).

In simple cases, it is easy to leave the markup out of the translatable strings, but in other cases, it would need a lot of cut strings which could bring problems too, if translated in isolation. In any case, the translation has to be reviewed and tested as any software change.

  1. I think the <li> "Login to the dbhub.io website (use your GitHub credentials or whatever you want)" is missing a period at the end (or the other <li>s should lose theirs for consistency). I did not add this period in their Portuguese translation, so if you change the source, just throw a period into the Portuguese translation too, please.

Yes, in cases like that, we should review and update the translations when the string is modified.

@mgrojo mgrojo merged commit 1e88dd8 into sqlitebrowser:master Jun 9, 2020
@mgrojo
Copy link
Member

mgrojo commented Jun 9, 2020

I've merged to the master and v3.12.x branches, and in the latter there are 16 untranslated strings. Could you review that branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants